Infra: Only add preview links for PRs to python/peps#4399
Merged
hugovk merged 2 commits intopython:mainfrom May 2, 2025
Merged
Infra: Only add preview links for PRs to python/peps#4399hugovk merged 2 commits intopython:mainfrom
python/peps#4399hugovk merged 2 commits intopython:mainfrom
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/ci/nodoclinkfork
branch
from
b1b9892 to
23195f4
Compare
henryiii
changed the title
hugovk
reviewed
May 2, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
AA-Turner
changed the title
python/peps
AA-Turner
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you make a fork, and then a coauthor makes a PR to that fork, a non-working docs link will get generated. This should fix this by making sure it's only being added to PRs to this repository, and not PRs to forks.
Example: henryiii#1
Though I need to try to test this in my fork to make sure,I think I have to test it by PR'ing into this branch on my fork. Edit: yes, it's working: henryiii#2pull_request_targetcan be tricky.📚 Documentation preview 📚: https://pep-previews--4399.org.readthedocs.build/